D10232: Include a pixel more in the dirty area
Marco Martin
noreply at phabricator.kde.org
Thu Feb 1 15:19:47 UTC 2018
mart created this revision.
mart added reviewers: Plasma, Konsole.
Restricted Application added projects: Plasma, Konsole.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.
REVISION SUMMARY
withfractional scaling sometimes there are visual glithches
in rendering.
painting areas of the terminal is heavily based on QRegion
which is all integer, and sometimes rounding errors can happen
this mitigates the problem, ensuring an area big enough gets
updated when repainting partial areas that cover eventual
pixel fractions that were rounded away
CCBUG:373232
TEST PLAN
most of the visual glitches are gone now, a missing pixel line
in the background very rarely still happening but seems a separate issue
somewhere else in the painting code
REPOSITORY
R319 Konsole
BRANCH
phab/dirty
REVISION DETAIL
https://phabricator.kde.org/D10232
AFFECTED FILES
src/TerminalDisplay.cpp
To: mart, #plasma, #konsole
Cc: plasma-devel, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, hindenburg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180201/ea147f12/attachment-0001.html>
More information about the Plasma-devel
mailing list