D17725: [RFC] Fix model updates in RunnerMatchesModel

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  I don't think it's necessary to optimize the `dataChanged` emits at this time - in the common case the roles the delegate is visualizing (label, icon) will always change, and the other rules are lazy-evaluated by the current UI (e.g. the context menu actions are constructed on-demand). Realistically, computing the roles delta to figure out the roles will likely eat more CPU time unless the users of the module show a different usage pattern. I'm OK with this with a "// TODO: Could be optimized by ... if needed" in the code.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17725

To: davidedmundson, #plasma, hein
Cc: hein, apol, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181222/0796c15a/attachment.html>