D17725: [RFC] Fix model updates in RunnerMatchesModel

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> runnermatchesmodel.cpp:225
>              emitDataChange = true;
> -
> -            break;
> +            m_matches[row] = matches.at(row);
>          }

Maybe it would make sense to only emit the ones that changed?

> runnermatchesmodel.cpp:230
> +    if (emitDataChange) {
> +        emit dataChanged(index(0, 0), index(ceiling - 1, 0));
> +    }

Can we specify which roles changed?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17725

To: davidedmundson, #plasma
Cc: apol, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181222/fb180b3a/attachment.html>