D17652: Fix logic error in kioclient noninteractive argument handling

[David Faure]

dfaure added a comment.


  No, the commit in 2006 wasn't buggy. There was special logic in KCmdLineArgs for the case of the "no" prefix (note how it said "ninteractive", the "no" was toggling the value). This is a porting error when going from KCmdLineArgs to QCommandLineParser.
  So it's "only" buggy since commit 48a9f87 <https://phabricator.kde.org/R126:48a9f87e56712003f1ab262ff16f757cbe149523> in 2014 :-)
  
  I like the idea of adding --interactive to avoid surprising existing users.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D17652

To: davidedmundson, #plasma, nerdopolist, dfaure
Cc: broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181218/23e3d5d2/attachment-0001.html>