D17533: Make the button's purpose more clear

[Pino Toscano]

pino added a comment.


  Regarding the use of bold: please note that using bold in some languages (usually eastern ones) either is not possible, or it does not make sense. So please do not solely rely on it to convey anything.

INLINE COMMENTS

> kaccess.cpp:671
>          dialog = new QDialog(nullptr);
> -        dialog->setWindowTitle(i18n("Warning"));
> +        dialog->setWindowTitle(i18n("Accessibility feature changes"));
>          dialog->setObjectName(QStringLiteral("AccessXWarning"));

Since you are changing this string: can you please use Title Capitalization as described in the HIG?
Also, adding a context like "@title:window" will help distinguish this as title.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17533

To: amantia, #plasma_accessibility, davidedmundson, aacid, ngraham
Cc: pino, gladhorn, ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181217/5f130376/attachment.html>