D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Nathaniel Graham]

ngraham added a comment.


  We're getting there!
  
  Right now, the tooltip appears if I click-and-hold for a moment, but not when I just click. Since that's the use case we're targeting, we should probably make it appear for click-and-quickly-release as well.

INLINE COMMENTS

> EdgeHandle.qml:36
> +        visible: false
> +        height: panel.location == PlasmaCore.Types.TopEdge || panel.location == PlasmaCore.Types.BottomEdge ? 40 : 60
> +        width: panel.location == PlasmaCore.Types.TopEdge || panel.location == PlasmaCore.Types.BottomEdge ? 190 : 130

Hardcoding heights and widths like this strikes me as likely to break for translated text, which could be much longer or shorter.

> EdgeHandle.qml:39
> +        x: parent.width / 2 - width / 2
> +        y: panel.location == PlasmaCore.Types.TopEdge || panel.location == PlasmaCore.Types.BottomEdge ? 32 : -62
> +        contentItem: PlasmaComponents.Label {

Like the widths and heights above, these magic numbers seem fragile. It's probably better to position using anchors rather than `x` and `y` values like this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181206/80a2df3a/attachment.html>