<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17323">View Revision</a></tr></table><br /><div><div><p>We're getting there!</p>

<p>Right now, the tooltip appears if I click-and-hold for a moment, but not when I just click. Since that's the use case we're targeting, we should probably make it appear for click-and-quickly-release as well.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17323#inline-95286">View Inline</a><span style="color: #4b4d51; font-weight: bold;">EdgeHandle.qml:36</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">visible:</span> <span style="color: #000a65">false</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">height:</span> <span style="color: #004012">panel</span><span class="p">.</span><span style="color: #004012">location</span> <span style="color: #aa2211">==</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">Types</span><span class="p">.</span><span style="color: #004012">TopEdge</span> <span style="color: #aa2211">||</span> <span style="color: #004012">panel</span><span class="p">.</span><span style="color: #004012">location</span> <span style="color: #aa2211">==</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">Types</span><span class="p">.</span><span style="color: #004012">BottomEdge</span> <span style="color: #aa2211">?</span> <span style="color: #601200">40</span> <span style="color: #aa2211">:</span> <span style="color: #601200">60</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">width:</span> <span style="color: #004012">panel</span><span class="p">.</span><span style="color: #004012">location</span> <span style="color: #aa2211">==</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">Types</span><span class="p">.</span><span style="color: #004012">TopEdge</span> <span style="color: #aa2211">||</span> <span style="color: #004012">panel</span><span class="p">.</span><span style="color: #004012">location</span> <span style="color: #aa2211">==</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">Types</span><span class="p">.</span><span style="color: #004012">BottomEdge</span> <span style="color: #aa2211">?</span> <span style="color: #601200">190</span> <span style="color: #aa2211">:</span> <span style="color: #601200">130</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Hardcoding heights and widths like this strikes me as likely to break for translated text, which could be much longer or shorter.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17323#inline-95288">View Inline</a><span style="color: #4b4d51; font-weight: bold;">EdgeHandle.qml:39</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">x:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">width</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span> <span style="color: #aa2211">-</span> <span style="color: #004012">width</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">y:</span> <span style="color: #004012">panel</span><span class="p">.</span><span style="color: #004012">location</span> <span style="color: #aa2211">==</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">Types</span><span class="p">.</span><span style="color: #004012">TopEdge</span> <span style="color: #aa2211">||</span> <span style="color: #004012">panel</span><span class="p">.</span><span style="color: #004012">location</span> <span style="color: #aa2211">==</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">Types</span><span class="p">.</span><span style="color: #004012">BottomEdge</span> <span style="color: #aa2211">?</span> <span style="color: #601200">32</span> <span style="color: #aa2211">:</span> <span style="color: #aa2211">-</span><span style="color: #601200">62</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">contentItem:</span> <span style="color: #004012">PlasmaComponents</span><span class="p">.</span><span style="color: #004012">Label</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Like the widths and heights above, these magic numbers seem fragile. It's probably better to position using anchors rather than <tt style="background: #ebebeb; font-size: 13px;">x</tt> and <tt style="background: #ebebeb; font-size: 13px;">y</tt> values like this.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17323">https://phabricator.kde.org/D17323</a></div></div><br /><div><strong>To: </strong>GB_2, Plasma, VDG<br /><strong>Cc: </strong>davidedmundson, matheusm, ngraham, trickyricky26, VDG, plasma-devel, Plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart<br /></div>