D14988: Implement option to toggle page navigation wraps around for pager plasmoid

Phuong Nguyen noreply at phabricator.kde.org
Tue Aug 28 12:35:42 BST 2018


phuongn marked an inline comment as done.
phuongn added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:130
> would
> 
>   var nextPage = plasmoid.configuration.wrapPage?
>                     (pagerModel.currentPage + 1) % repeater.count :
>                      Math.max(pagerModel.currentPage + 1, repeater.count)
> 
> be more readable?

Agree. Sorry I wasn't aware of Math functions in the context. Good tip 👍

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14988

To: phuongn, #plasma, #vdg
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180828/3159953b/attachment.html>


More information about the Plasma-devel mailing list