D14857: Label job notifications with destination file name
Karthik Periagaram
noreply at phabricator.kde.org
Wed Aug 15 10:25:30 BST 2018
karthikp created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
karthikp requested review of this revision.
REVISION SUMMARY
If a destination file name is present, it is a better label for a job
than the source file name. This is particularly true for web downloads
where the source file name may be a gibberish base64 string while the
destination file name would be selected by the user.
If there is no destination file name, we fall back to using the source
file name.
BUG: 396744
TEST PLAN
Compiles, built-in tests pass. Not sure about coverage.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D14857
AFFECTED FILES
applets/notifications/package/contents/ui/JobDelegate.qml
To: karthikp
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180815/2bee69e1/attachment.html>
More information about the Plasma-devel
mailing list