D14822: Use QJSValue as method parameter type for the scripting interface

Fabian Vogt noreply at phabricator.kde.org
Tue Aug 14 12:00:07 BST 2018


fvogt added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in applet.cpp:139
> So writeEntry gets QJSValue& now why you call again toVariant(), here everywhere else.

KConfigGroup != ConfigGroup. d->configGroup is from kconfig and does not take QJSValue. That's the core of the bugfix.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14822

To: fvogt, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180814/dabea250/attachment.html>


More information about the Plasma-devel mailing list