D14822: Use QJSValue as method parameter type for the scripting interface

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> applet.cpp:139
>  
> -        d->configGroup.writeEntry(key, value);
> +        d->configGroup.writeEntry(key, value.toVariant());
>          d->configDirty = true;

So writeEntry gets QJSValue& now why you call again toVariant(), here everywhere else.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14822

To: fvogt, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180814/cb932d1c/attachment.html>