D14651: [Notifications Engine] Guard "this"

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Aug 6 15:05:54 BST 2018


broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, jgrulich.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  On teardown with the popup expanded, the cleanup handler might fire with us already having been deleted.
  
  BUG: 397105
  FIXED-IN: 5.12.7

TEST PLAN
  - `plasmawindowed org.kde.plasma.networkmanagement` no longer crashes on quit
  - Verified that `NotificationInhibiton` is still properly cleaned up when closing the popup in normal use (only after the GC kicks in, though)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14651

AFFECTED FILES
  dataengines/notifications/notificationsengine.cpp

To: broulik, #plasma, davidedmundson, jgrulich
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180806/af7c857d/attachment.html>


More information about the Plasma-devel mailing list