<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, davidedmundson, jgrulich.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14651">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>On teardown with the popup expanded, the cleanup handler might fire with us already having been deleted.</p>
<p>BUG: 397105<br />
FIXED-IN: 5.12.7</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">plasmawindowed org.kde.plasma.networkmanagement</tt> no longer crashes on quit</li>
<li class="remarkup-list-item">Verified that <tt style="background: #ebebeb; font-size: 13px;">NotificationInhibiton</tt> is still properly cleaned up when closing the popup in normal use (only after the GC kicks in, though)</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14651">https://phabricator.kde.org/D14651</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>dataengines/notifications/notificationsengine.cpp</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, davidedmundson, jgrulich<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>