D14649: Fwupd-Backend (Fixes)

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Aug 6 14:34:48 BST 2018


apol added a comment.


  Reviewing the patch with such menial styling changes becomes to hard, please clean up first.
  
  The spaces change is indeed correct, maybe just commit that part first, for easier review.

INLINE COMMENTS

> FwupdBackend.h:84
>      const QUrl cacheFile(const QString &kind, const QFileInfo &resource);
> -    FwupdResource * createDevice(FwupdDevice *device);
> -    FwupdResource * createRelease(FwupdDevice *device);
> -    FwupdResource * createApp(FwupdDevice *device);
> +    FwupdResource * createDevice(FwupdDevice *dev);
> +    FwupdResource * createRelease(FwupdDevice *dev);

Why did you change all `device` to `dev`?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D14649

To: abhijeet2096, apol, davidedmundson
Cc: plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180806/a10a04bd/attachment-0001.html>


More information about the Plasma-devel mailing list