<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14649">View Revision</a></tr></table><br /><div><div><p>Reviewing the patch with such menial styling changes becomes to hard, please clean up first.</p>

<p>The spaces change is indeed correct, maybe just commit that part first, for easier review.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14649#inline-77409">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FwupdBackend.h:84</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span style="color: #004012">cacheFile</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">kind</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QFileInfo</span> <span style="color: #aa2211">&</span><span class="n">resource</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">FwupdResource</span> <span style="color: #aa2211">*</span> <span style="color: #004012">createDevice</span><span class="p">(</span><span class="n">FwupdDevice</span> <span style="color: #aa2211">*</span><span class="n">dev<span class="bright">ice</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">FwupdResource</span> <span style="color: #aa2211">*</span> <span style="color: #004012">createRelease</span><span class="p">(</span><span class="n">FwupdDevice</span> <span style="color: #aa2211">*</span><span class="n">dev<span class="bright">ice</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">FwupdResource</span> <span style="color: #aa2211">*</span> <span style="color: #004012">createDevice</span><span class="p">(</span><span class="n">FwupdDevice</span> <span style="color: #aa2211">*</span><span class="n">dev</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">FwupdResource</span> <span style="color: #aa2211">*</span> <span style="color: #004012">createRelease</span><span class="p">(</span><span class="n">FwupdDevice</span> <span style="color: #aa2211">*</span><span class="n">dev</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why did you change all <tt style="background: #ebebeb; font-size: 13px;">device</tt> to <tt style="background: #ebebeb; font-size: 13px;">dev</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R134 Discover Software Store</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14649">https://phabricator.kde.org/D14649</a></div></div><br /><div><strong>To: </strong>abhijeet2096, apol, davidedmundson<br /><strong>Cc: </strong>plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>