D14545: Support both QString and QIcon for dragHelper pixmap

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The model was changed a while ago to return a QString if possible to have icon processing done in the delegate QML on-demand. This broke the drag helper's drag pixmap, however, as the QML would pass in `model.decoration` which might be a `string`.

TEST PLAN
  5.12
  
  - Have proper drag pixmaps for all entries again
  - Custom icons (e.g. favicon) still work

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D14545

AFFECTED FILES
  lib/draghelper.cpp
  lib/draghelper.h

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180802/094113bd/attachment.html>