D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

[Chris Holland]

Zren added a comment.


  I use `gcc --version 5.4.0`, so I've no idea. I assume that is a QPointer feature though? We can always check the other DownloadDialog initializations:
  
  - Image Wallpapers added `m_newStuffDialog->setWindowModality(...)` 9 months ago:
    - https://github.com/KDE/plasma-workspace/blame/master/wallpapers/image/image.cpp#L600
    - https://github.com/KDE/plasma-workspace/commit/3558afa9579edffb5f86d36973cf42c560126569
  - Widget Explorer only uses `data()` https://github.com/KDE/plasma-workspace/blame/master/components/shellprivate/widgetexplorer/widgetexplorer.cpp#L443
  - Desktop Theme uses `data()` and  `m_newStuffDialog->setWindowModality(...)`, but it was changed today:
    - https://github.com/KDE/plasma-desktop/blame/master/kcms/desktoptheme/kcm.cpp#L126
    - It was using `dialog->open()` before today, which was last changed 2 years ago: https://github.com/KDE/plasma-desktop/blame/9a333b48ca1af8fc9ea07ee4b154fe09d5485e1b/kcms/desktoptheme/kcm.cpp#L97
  - Look and Feel only uses `data()` https://github.com/KDE/plasma-desktop/blame/master/kcms/lookandfeel/kcm.cpp#L109
  - Icon Themes uses `dialog.exec()` ... which is blocking I think. Doesn't mention `data()` anywhere though.  https://github.com/KDE/plasma-desktop/blame/master/kcms/icons/iconthemes.cpp#L319
  - Cursor Theme is similar to Icon Theme with `dialog.exec()` https://github.com/KDE/plasma-desktop/blame/master/kcms/cursortheme/kcmcursortheme.cpp#L446
  - Emoticon Themes  is similar to Icon Theme with `dialog.exec()` https://github.com/KDE/plasma-desktop/blame/master/kcms/emoticons/emoticonslist.cpp#L426
  - Color Themes is similar to Icon Theme with `dialog.exec()` https://github.com/KDE/plasma-desktop/blame/master/kcms/colors/colorscm.cpp#L293

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180425/1909c718/attachment.html>