<table><tr><td style="">Zren added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12040">View Revision</a></tr></table><br /><div><div><p>I use <tt style="background: #ebebeb; font-size: 13px;">gcc --version 5.4.0</tt>, so I've no idea. I assume that is a QPointer feature though? We can always check the other DownloadDialog initializations:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Image Wallpapers added <tt style="background: #ebebeb; font-size: 13px;">m_newStuffDialog->setWindowModality(...)</tt> 9 months ago:<ul class="remarkup-list">
<li class="remarkup-list-item"><a href="https://github.com/KDE/plasma-workspace/blame/master/wallpapers/image/image.cpp#L600" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/plasma-workspace/blame/master/wallpapers/image/image.cpp#L600</a></li>
<li class="remarkup-list-item"><a href="https://github.com/KDE/plasma-workspace/commit/3558afa9579edffb5f86d36973cf42c560126569" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/plasma-workspace/commit/3558afa9579edffb5f86d36973cf42c560126569</a></li>
</ul></li>
<li class="remarkup-list-item">Widget Explorer only uses <tt style="background: #ebebeb; font-size: 13px;">data()</tt> <a href="https://github.com/KDE/plasma-workspace/blame/master/components/shellprivate/widgetexplorer/widgetexplorer.cpp#L443" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/plasma-workspace/blame/master/components/shellprivate/widgetexplorer/widgetexplorer.cpp#L443</a></li>
<li class="remarkup-list-item">Desktop Theme uses <tt style="background: #ebebeb; font-size: 13px;">data()</tt> and  <tt style="background: #ebebeb; font-size: 13px;">m_newStuffDialog->setWindowModality(...)</tt>, but it was changed today:<ul class="remarkup-list">
<li class="remarkup-list-item"><a href="https://github.com/KDE/plasma-desktop/blame/master/kcms/desktoptheme/kcm.cpp#L126" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/plasma-desktop/blame/master/kcms/desktoptheme/kcm.cpp#L126</a></li>
<li class="remarkup-list-item">It was using <tt style="background: #ebebeb; font-size: 13px;">dialog->open()</tt> before today, which was last changed 2 years ago: <a href="https://github.com/KDE/plasma-desktop/blame/9a333b48ca1af8fc9ea07ee4b154fe09d5485e1b/kcms/desktoptheme/kcm.cpp#L97" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/plasma-desktop/blame/9a333b48ca1af8fc9ea07ee4b154fe09d5485e1b/kcms/desktoptheme/kcm.cpp#L97</a></li>
</ul></li>
<li class="remarkup-list-item">Look and Feel only uses <tt style="background: #ebebeb; font-size: 13px;">data()</tt> <a href="https://github.com/KDE/plasma-desktop/blame/master/kcms/lookandfeel/kcm.cpp#L109" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/plasma-desktop/blame/master/kcms/lookandfeel/kcm.cpp#L109</a></li>
<li class="remarkup-list-item">Icon Themes uses <tt style="background: #ebebeb; font-size: 13px;">dialog.exec()</tt> ... which is blocking I think. Doesn't mention <tt style="background: #ebebeb; font-size: 13px;">data()</tt> anywhere though.  <a href="https://github.com/KDE/plasma-desktop/blame/master/kcms/icons/iconthemes.cpp#L319" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/plasma-desktop/blame/master/kcms/icons/iconthemes.cpp#L319</a></li>
<li class="remarkup-list-item">Cursor Theme is similar to Icon Theme with <tt style="background: #ebebeb; font-size: 13px;">dialog.exec()</tt> <a href="https://github.com/KDE/plasma-desktop/blame/master/kcms/cursortheme/kcmcursortheme.cpp#L446" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/plasma-desktop/blame/master/kcms/cursortheme/kcmcursortheme.cpp#L446</a></li>
<li class="remarkup-list-item">Emoticon Themes  is similar to Icon Theme with <tt style="background: #ebebeb; font-size: 13px;">dialog.exec()</tt> <a href="https://github.com/KDE/plasma-desktop/blame/master/kcms/emoticons/emoticonslist.cpp#L426" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/plasma-desktop/blame/master/kcms/emoticons/emoticonslist.cpp#L426</a></li>
<li class="remarkup-list-item">Color Themes is similar to Icon Theme with <tt style="background: #ebebeb; font-size: 13px;">dialog.exec()</tt> <a href="https://github.com/KDE/plasma-desktop/blame/master/kcms/colors/colorscm.cpp#L293" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/plasma-desktop/blame/master/kcms/colors/colorscm.cpp#L293</a></li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12040">https://phabricator.kde.org/D12040</a></div></div><br /><div><strong>To: </strong>Zren, Plasma<br /><strong>Cc: </strong>cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>