D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> sharvey wrote in SettingsBase.cpp:82
> So should I just run the "preferred size" (1024x760) through the `boundedTo` function for odd-sized screens? In other words, ditch the scale factor completely? As in:
> 
>   const QSize screenSize = (QGuiApplication::primaryScreen()->availableSize()*0.9);
>   const QSize targetSize = QSize(1024, 700);
>   return targetSize.boundedTo(screenSize);
> 
> I thought I'd ask before updating the diff for the 19th time.  :-)

Confirmed. This works fine for me, so you can just remove the `factor` part entirely. Sorry for sending you down the wrong path!

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart, davidedmundson
Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180422/11642126/attachment.html>