D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Scott Harvey]

sharvey added inline comments.

INLINE COMMENTS

> davidedmundson wrote in SettingsBase.cpp:82
> > qreal factor = qBound(1.0, QGuiApplication::primaryScreen()->devicePixelRatio()/96., 3.0);
> 
> I know you were told to change to this, but don't do that.
> 
> Qt will scale the size you give it here by the devicePixelRatio. This is scaling it twice which we don't want to do.
> 
> We shouldn't need to be doing any custom high DPI code in window sizing.

So should I just run the "preferred size" (1024x760) through the `boundedTo` function for odd-sized screens? In other words, ditch the scale factor completely? As in:

  const QSize screenSize = (QGuiApplication::primaryScreen()->availableSize()*0.9);
  const QSize targetSize = QSize(1024, 700);
  return targetSize.boundedTo(screenSize);

I thought I'd ask before updating the diff for the 19th time.  :-)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart, davidedmundson
Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180417/71363bec/attachment.html>