D12323: Read theme.conf of themes

David Edmundson noreply at phabricator.kde.org
Wed Apr 18 18:32:13 UTC 2018


davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  1 minor change.

INLINE COMMENTS

> themeconfig.cpp:169
>      if (configFile.exists()) {
> -        KSharedConfigPtr themeConfig = KSharedConfig::openConfig(configFile.fileName() + ".user", KConfig::SimpleConfig);
> +        KSharedConfigPtr themeConfig = KSharedConfig::openConfig(configFile.fileName() + ".user", KConfig::CascadeConfig);
> +        themeConfig->addConfigSources({configFile.fileName()});

nice solution

"NoGlobals" - Cascade to system settings, but omit user's globals.

should work better. It will include the added sources, but no more

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12323

To: fvogt, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180418/8c94664a/attachment.html>


More information about the Plasma-devel mailing list