<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12323">View Revision</a></tr></table><br /><div><div><p>1 minor change.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12323#inline-62382">View Inline</a><span style="color: #4b4d51; font-weight: bold;">themeconfig.cpp:169</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">configFile</span><span class="p">.</span><span class="n">exists</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">KSharedConfigPtr</span> <span class="n">themeConfig</span> <span style="color: #aa2211">=</span> <span class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span class="n">openConfig</span><span class="p">(</span><span class="n">configFile</span><span class="p">.</span><span class="n">fileName</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">".user"</span><span class="p">,</span> <span class="n">KConfig</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">Simpl</span>eConfig</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">KSharedConfigPtr</span> <span class="n">themeConfig</span> <span style="color: #aa2211">=</span> <span class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span class="n">openConfig</span><span class="p">(</span><span class="n">configFile</span><span class="p">.</span><span class="n">fileName</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">".user"</span><span class="p">,</span> <span class="n">KConfig</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">Cascad</span>eConfig</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">themeConfig</span><span style="color: #aa2211">-></span><span class="n">addConfigSources</span><span class="p">({</span><span class="n">configFile</span><span class="p">.</span><span class="n">fileName</span><span class="p">()});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">nice solution</p>

<p style="padding: 0; margin: 8px;">"NoGlobals" - Cascade to system settings, but omit user's globals.</p>

<p style="padding: 0; margin: 8px;">should work better. It will include the added sources, but no more</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R123 SDDM Configuration Panel (KCM)</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12323">https://phabricator.kde.org/D12323</a></div></div><br /><div><strong>To: </strong>fvogt, Plasma, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>