D12248: [Desktop Theme KCM] Port to new design
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Apr 16 15:52:49 UTC 2018
broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
The preview code could luckily be left completely untouched.
TEST PLAN
- Verified that current index is correct upon opening
- Verified that changing themes works
- Verified that "open from file" works
- Verified that GHNS works
- Verified that theme removal works (is now animated, the delegate zooms out like a plasmoid on the desktop) and then the other items move ot fill the gap
F5809788: Screenshot_20180416_174837.png <https://phabricator.kde.org/F5809788>
In case of error I used the new `InlineMessage` (before it would just show a small label next to the buttons)
F5809789: Screenshot_20180416_175219.png <https://phabricator.kde.org/F5809789>
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D12248
AFFECTED FILES
kcms/desktoptheme/kcm.cpp
kcms/desktoptheme/kcm.h
kcms/desktoptheme/package/contents/ui/main.qml
To: broulik, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180416/4988e07b/attachment.html>
More information about the Plasma-devel
mailing list