<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, VDG.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12248">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The preview code could luckily be left completely untouched.</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Verified that current index is correct upon opening</li>
<li class="remarkup-list-item">Verified that changing themes works</li>
<li class="remarkup-list-item">Verified that "open from file" works</li>
<li class="remarkup-list-item">Verified that GHNS works</li>
<li class="remarkup-list-item">Verified that theme removal works (is now animated, the delegate zooms out like a plasmoid on the desktop) and then the other items move ot fill the gap</li>
</ul>
<p><a href="https://phabricator.kde.org/F5809788" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5809788: Screenshot_20180416_174837.png</a><br />
In case of error I used the new <tt style="background: #ebebeb; font-size: 13px;">InlineMessage</tt> (before it would just show a small label next to the buttons)<br />
<a href="https://phabricator.kde.org/F5809789" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5809789: Screenshot_20180416_175219.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12248">https://phabricator.kde.org/D12248</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcms/desktoptheme/kcm.cpp<br />
kcms/desktoptheme/kcm.h<br />
kcms/desktoptheme/package/contents/ui/main.qml</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>