D12088: port the ksplash kcm to the new design

David Edmundson noreply at phabricator.kde.org
Wed Apr 11 16:45:47 UTC 2018


davidedmundson added inline comments.

INLINE COMMENTS

> mart wrote in main.qml:60
> > You shouldn't have told me that :)
> > I have one consistent rule about working round Qt bugs, it needs an upstream report and a link in the code.
> 
> I am not completely sure is actually a Qt bug... not sure it would be possible to have some finished signal, as depending on how the model behaves, you can never be sure that the representation is "completed" as the model can change at any moment?

> ou can never be sure that the representation is "completed" as the model can change at any moment?

It must know internally as it has that separate populate and add transition.

It shouldn't need an external signal. In a perfect world:

ListView {

  model: someValidModel
  currentIndex: 4 

}

should "just work"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12088

To: mart, #plasma, #vdg
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180411/e0937ef2/attachment.html>


More information about the Plasma-devel mailing list