D12088: port the ksplash kcm to the new design

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:60
> You shouldn't have told me that :)
> 
> I have one consistent rule about working round Qt bugs, it needs an upstream report and a link in the code.
> 
> -----
> 
> but in any case, your comment doesn't explain why we need:
>  view.positionViewAtIndex(grid.currentIndex, GridView.Visible)
> 
> If we've just changed the index, we'll run onCurrentIndexChanged which does it's own view.positionViewAt()  .
> 
> Unless we need to position the view even when we don't change the index?

> You shouldn't have told me that :)
> I have one consistent rule about working round Qt bugs, it needs an upstream report and a link in the code.

I am not completely sure is actually a Qt bug... not sure it would be possible to have some finished signal, as depending on how the model behaves, you can never be sure that the representation is "completed" as the model can change at any moment?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12088

To: mart, #plasma, #vdg
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180411/c6aa3d26/attachment.html>