D12040: [WIP] Add wallpaperplugin.knsrc + QML function to open GHNS dialog
Chris Holland
noreply at phabricator.kde.org
Sun Apr 8 06:31:10 UTC 2018
Zren created this revision.
Zren added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Zren requested review of this revision.
REVISION SUMMARY
Patch 1/2 (other patch is for plasma-desktop)
BUG: #386621
- https://bugs.kde.org/show_bug.cgi?id=386621
- To find the `Categories=Plasma Wallpaper Plugin` in the `wallpaperplugin.knsrc`, I had to find the `<name>Plasma Wallpaper Plugin</name>` on the this API url: https://api.kde-look.org/ocs/v1/content/categories
- To find that url, I looked at: https://github.com/KDE/ocs-webserver/blob/master/application/modules/default/Bootstrap.php#L1014
Screenshot of the dialog:
F5800268: 2018-04-08___02-02-49.png <https://phabricator.kde.org/F5800268>
This screenshot is more releavant to Patch 2 for plasma-desktop:
F5800267: 2018-04-08___02-19-12.png <https://phabricator.kde.org/F5800267>
TODO:
-----
[ ] Move C++ plugin to `components/shellprivate/wallpaperplugin` ? I probably need to move the new GHNS code to `components/shellprivate/wallpaperplugin` since "desktoppackage" has the widgetexplorer C++ plugins there. I figured I'd put up a working patch first.
[ ] Update `wallpaperComboBox` and `configDialog.wallpaperConfigModel` so we don't have to close and reopen the "Configure Desktop" window for the plugin to show up in the dropdown.
TEST PLAN
1. Install both patches
2. Configure Desktop > Get Wallpaper Plugins > Install something (eg: Ken Burns Effect)
3. Confirm it showed up in `~/.local/share/plasma/wallpapers/`
4. Close GHNS dialog and Configure Desktop dialog
5. Reopen Configure Desktop
6. Confirm "Ken Burns Effect" shows up
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D12040
AFFECTED FILES
wallpapers/image/CMakeLists.txt
wallpapers/image/image.cpp
wallpapers/image/image.h
wallpapers/image/wallpaperplugin.knsrc
To: Zren, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180408/400b85f9/attachment-0001.html>
More information about the Plasma-devel
mailing list