<table><tr><td style="">Zren created this revision.<br />Zren added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />Zren requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12040">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Patch 1/2 (other patch is for plasma-desktop)</p>
<p>BUG: #386621</p>
<ul class="remarkup-list">
<li class="remarkup-list-item"><a href="https://bugs.kde.org/show_bug.cgi?id=386621" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=386621</a></li>
<li class="remarkup-list-item">To find the <tt style="background: #ebebeb; font-size: 13px;">Categories=Plasma Wallpaper Plugin</tt> in the <tt style="background: #ebebeb; font-size: 13px;">wallpaperplugin.knsrc</tt>, I had to find the <tt style="background: #ebebeb; font-size: 13px;"><name>Plasma Wallpaper Plugin</name></tt> on the this API url: <a href="https://api.kde-look.org/ocs/v1/content/categories" class="remarkup-link" target="_blank" rel="noreferrer">https://api.kde-look.org/ocs/v1/content/categories</a></li>
<li class="remarkup-list-item">To find that url, I looked at: <a href="https://github.com/KDE/ocs-webserver/blob/master/application/modules/default/Bootstrap.php#L1014" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/ocs-webserver/blob/master/application/modules/default/Bootstrap.php#L1014</a></li>
</ul>
<p>Screenshot of the dialog:</p>
<p><a href="https://phabricator.kde.org/F5800268" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5800268: 2018-04-08___02-02-49.png</a></p>
<p>This screenshot is more releavant to Patch 2 for plasma-desktop:</p>
<p><a href="https://phabricator.kde.org/F5800267" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5800267: 2018-04-08___02-19-12.png</a></p>
<h3 class="remarkup-header">TODO:</h3>
<ul class="remarkup-list remarkup-list-with-checkmarks">
<li class="remarkup-list-item remarkup-unchecked-item"><input type="checkbox" disabled="disabled" /> Move C++ plugin to <tt style="background: #ebebeb; font-size: 13px;">components/shellprivate/wallpaperplugin</tt> ? I probably need to move the new GHNS code to <tt style="background: #ebebeb; font-size: 13px;">components/shellprivate/wallpaperplugin</tt> since "desktoppackage" has the widgetexplorer C++ plugins there. I figured I'd put up a working patch first.</li>
<li class="remarkup-list-item remarkup-unchecked-item"><input type="checkbox" disabled="disabled" /> Update <tt style="background: #ebebeb; font-size: 13px;">wallpaperComboBox</tt> and <tt style="background: #ebebeb; font-size: 13px;">configDialog.wallpaperConfigModel</tt> so we don't have to close and reopen the "Configure Desktop" window for the plugin to show up in the dropdown.</li>
</ul></div></div><br /><div><strong>TEST PLAN</strong><div><ol class="remarkup-list">
<li class="remarkup-list-item">Install both patches</li>
<li class="remarkup-list-item">Configure Desktop > Get Wallpaper Plugins > Install something (eg: Ken Burns Effect)</li>
<li class="remarkup-list-item">Confirm it showed up in <tt style="background: #ebebeb; font-size: 13px;">~/.local/share/plasma/wallpapers/</tt></li>
<li class="remarkup-list-item">Close GHNS dialog and Configure Desktop dialog</li>
<li class="remarkup-list-item">Reopen Configure Desktop</li>
<li class="remarkup-list-item">Confirm "Ken Burns Effect" shows up</li>
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12040">https://phabricator.kde.org/D12040</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>wallpapers/image/CMakeLists.txt<br />
wallpapers/image/image.cpp<br />
wallpapers/image/image.h<br />
wallpapers/image/wallpaperplugin.knsrc</div></div></div><br /><div><strong>To: </strong>Zren, Plasma<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>