D8039: Support software QtQuickRendering in Aurorae

Martin Flöser noreply at phabricator.kde.org
Fri Sep 29 15:49:12 UTC 2017


graesslin added inline comments.

INLINE COMMENTS

> aurorae.cpp:354
>              [this] {
>                  if (!m_context->makeCurrent(m_offscreenSurface.data())) {
>                      return;

stupid question: but why is this code working? I would assume that making the context current will fail here and then we return? And even if the creation of the FBO should fail and then also return?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8039

To: davidedmundson, #plasma
Cc: graesslin, apol, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170929/957470e0/attachment-0001.html>


More information about the Plasma-devel mailing list