D7940: plugin loaded by kirigami to use KColorScheme and KIconLoader

Marco Martin noreply at phabricator.kde.org
Tue Sep 26 12:38:56 UTC 2017


mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in plasmadesktoptheme.cpp:34
> I can't find Kirigami::PlatformTheme? Is the review published?

it's in the giant https://phabricator.kde.org/D7939

> davidedmundson wrote in plasmadesktoptheme.h:73
> how are they legacy?

should be better documented...
the idea is to go from
Rectangle {

  color: Theme.viewBackgroundColor

}

to

Rectangle {

  Theme.colorSet: Theme.View
  color: Theme.backgroundColor

}

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7940

To: mart, #plasma, #kirigami, hein
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170926/d0c04ff8/attachment.html>


More information about the Plasma-devel mailing list