D7940: plugin loaded by kirigami to use KColorScheme and KIconLoader

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> plasmadesktoptheme.cpp:34
> +PlasmaDesktopTheme::PlasmaDesktopTheme(QObject *parent)
> +    : PlatformTheme(parent)
> +{

I can't find Kirigami::PlatformTheme? Is the review published?

> plasmadesktoptheme.h:73
> +private:
> +    //legacy colors
> +    QColor m_buttonTextColor;

how are they legacy?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7940

To: mart, #plasma, #kirigami, hein
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170925/7ab62a89/attachment.html>