D7897: Move X11 specific Workspace initialization code into dedicated method

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in workspace.cpp:381
> `kwinApp()->x11Connection()`?

Yes, in a future change :-) Currently this only moves code around and tries to not change too much.

Some time in the near to distant future connection() will have to die as well as rootWindow(), but that will be one big global search and replace commit.

> broulik wrote in workspace.cpp:397
> Now superfluous, also below

No, I added this TODO, it's not superfluous. This code is still called on Wayland if you use XWayland. The TODO says this should only be done in kwin_x11, but not in kwin_wayland.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7897

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170921/cfeebaf8/attachment-0001.html>