D7897: Move X11 specific Workspace initialization code into dedicated method

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Sep 20 20:08:48 UTC 2017


broulik added inline comments.

INLINE COMMENTS

> workspace.cpp:381
> +
> +    xcb_change_property(connection(), XCB_PROP_MODE_APPEND, rootWindow(), atoms->kwin_running,
> +                        atoms->kwin_running, 32, 1, &data);

`kwinApp()->x11Connection()`?

> workspace.cpp:397
> +
> +    // TODO: only in X11 mode
> +    // Extra NETRootInfo instance in Client mode is needed to get the values of the properties

Now superfluous, also below

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7897

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170920/102be457/attachment.html>


More information about the Plasma-devel mailing list