D7761: [effects] Support xcbConnectionChanged for support properties

David Edmundson noreply at phabricator.kde.org
Sun Sep 10 15:52:38 UTC 2017


davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> contrast.cpp:63
> +        [this] {
> +            net_wm_contrast_region = effects->announceSupportProperty(s_contrastAtomName, this);
> +        }

we should only announce this 
 if ((shader && shader->isValid())

> blur.cpp:78
> +        [this] {
> +            net_wm_blur_region = effects->announceSupportProperty(s_blurAtomName, this);
> +        }

same here.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7761

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170910/8faee1c1/attachment.html>


More information about the Plasma-devel mailing list