D7761: [effects] Support xcbConnectionChanged for support properties

Martin Flöser noreply at phabricator.kde.org
Sun Sep 10 14:56:09 UTC 2017


graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Several effects announce a support property atom on the root window. This
  change forwards the KWin::Application's signal that the xcbConnection
  changed to the EffectsHandler so that the effects can respond to it.
  
  All effects which announce a support property connect to this new signal
  and re-announce the property. In case the xcb connection died (future
  XWayland crashing case) it is set to XCB_ATOM_NONE by that. In case the
  xcb connection got created (future delayed XWayland startup) the atom is
  set to the proper value.
  
  In addition all usages of the support properties are guarded, so that no
  nonesense actions are performed if the support property is XCB_ATOM_NONE.

TEST PLAN
  Only compile tested as we don't have XFree KWin yet

REPOSITORY
  R108 KWin

BRANCH
  effects-xcb-connection-changed

REVISION DETAIL
  https://phabricator.kde.org/D7761

AFFECTED FILES
  effects.cpp
  effects/backgroundcontrast/contrast.cpp
  effects/blur/blur.cpp
  effects/highlightwindow/highlightwindow.cpp
  effects/kscreen/kscreen.cpp
  effects/presentwindows/presentwindows.cpp
  effects/slidingpopups/slidingpopups.cpp
  libkwineffects/kwineffects.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170910/b1c2eb24/attachment.html>


More information about the Plasma-devel mailing list