D7740: Move SceneOpenGL into a dedicated plugin
Martin Flöser
noreply at phabricator.kde.org
Fri Sep 8 20:42:36 UTC 2017
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Unfortunately a rather large change which required more refactoring than
initially expected. The main problem was that some parts needed to go
into platformsupport so that the platform plugins can link them. Due to
the rather monolithic nature of scene_opengl.h a few changes were
required:
- SceneOpenGL::Texture -> SceneOpenGLTexture
- SceneOpenGL::TexturePrivate -> SceneOpenGLTexturePrivate
- texture based code into dedicated files
- SwapProfiler code into dedicated files
- SwapProfiler only used in x11 variants
- Safety checks for OpenGL scene moved into the new plugin
- signal declared in SceneOpenGL moved to Scene, so that we don't need
to include SceneOpenGL in composite
TEST PLAN
Nested OpenGL compositor works
REPOSITORY
R108 KWin
BRANCH
scene-opengl-plugin
REVISION DETAIL
https://phabricator.kde.org/D7740
AFFECTED FILES
CMakeLists.txt
abstract_egl_backend.cpp
abstract_egl_backend.h
composite.cpp
data/org_kde_kwin.categories
lanczosfilter.h
libkwineffects/kwingltexture_p.h
platformsupport/scenes/CMakeLists.txt
platformsupport/scenes/opengl/CMakeLists.txt
platformsupport/scenes/opengl/abstract_egl_backend.cpp
platformsupport/scenes/opengl/abstract_egl_backend.h
platformsupport/scenes/opengl/backend.cpp
platformsupport/scenes/opengl/backend.h
platformsupport/scenes/opengl/swap_profiler.cpp
platformsupport/scenes/opengl/swap_profiler.h
platformsupport/scenes/opengl/texture.cpp
platformsupport/scenes/opengl/texture.h
plugins/platforms/drm/CMakeLists.txt
plugins/platforms/drm/egl_gbm_backend.cpp
plugins/platforms/drm/egl_gbm_backend.h
plugins/platforms/hwcomposer/CMakeLists.txt
plugins/platforms/hwcomposer/egl_hwcomposer_backend.cpp
plugins/platforms/hwcomposer/egl_hwcomposer_backend.h
plugins/platforms/virtual/CMakeLists.txt
plugins/platforms/virtual/egl_gbm_backend.cpp
plugins/platforms/virtual/egl_gbm_backend.h
plugins/platforms/virtual/virtual_backend.cpp
plugins/platforms/wayland/CMakeLists.txt
plugins/platforms/wayland/egl_wayland_backend.cpp
plugins/platforms/wayland/egl_wayland_backend.h
plugins/platforms/x11/common/CMakeLists.txt
plugins/platforms/x11/common/eglonxbackend.cpp
plugins/platforms/x11/common/eglonxbackend.h
plugins/platforms/x11/standalone/CMakeLists.txt
plugins/platforms/x11/standalone/glxbackend.cpp
plugins/platforms/x11/standalone/glxbackend.h
plugins/platforms/x11/windowed/CMakeLists.txt
plugins/platforms/x11/windowed/x11windowed_backend.cpp
plugins/scenes/CMakeLists.txt
plugins/scenes/opengl/CMakeLists.txt
plugins/scenes/opengl/opengl.json
plugins/scenes/opengl/scene_opengl.cpp
plugins/scenes/opengl/scene_opengl.h
scene.h
scene_opengl.cpp
scene_opengl.h
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170908/990a5f6e/attachment.html>
More information about the Plasma-devel
mailing list