<table><tr><td style="">graesslin created this revision.<br />Restricted Application added a project: KWin.<br />Restricted Application added subscribers: kwin, plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7740" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Unfortunately a rather large change which required more refactoring than<br />
initially expected. The main problem was that some parts needed to go<br />
into platformsupport so that the platform plugins can link them. Due to<br />
the rather monolithic nature of scene_opengl.h a few changes were<br />
required:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">SceneOpenGL::Texture -> SceneOpenGLTexture</li>
<li class="remarkup-list-item">SceneOpenGL::TexturePrivate -> SceneOpenGLTexturePrivate</li>
<li class="remarkup-list-item">texture based code into dedicated files</li>
<li class="remarkup-list-item">SwapProfiler code into dedicated files</li>
<li class="remarkup-list-item">SwapProfiler only used in x11 variants</li>
<li class="remarkup-list-item">Safety checks for OpenGL scene moved into the new plugin</li>
<li class="remarkup-list-item">signal declared in SceneOpenGL moved to Scene, so that we don't need</li>
</ul>

<p>to include SceneOpenGL in composite</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Nested OpenGL compositor works</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>scene-opengl-plugin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7740" rel="noreferrer">https://phabricator.kde.org/D7740</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
abstract_egl_backend.cpp<br />
abstract_egl_backend.h<br />
composite.cpp<br />
data/org_kde_kwin.categories<br />
lanczosfilter.h<br />
libkwineffects/kwingltexture_p.h<br />
platformsupport/scenes/CMakeLists.txt<br />
platformsupport/scenes/opengl/CMakeLists.txt<br />
platformsupport/scenes/opengl/abstract_egl_backend.cpp<br />
platformsupport/scenes/opengl/abstract_egl_backend.h<br />
platformsupport/scenes/opengl/backend.cpp<br />
platformsupport/scenes/opengl/backend.h<br />
platformsupport/scenes/opengl/swap_profiler.cpp<br />
platformsupport/scenes/opengl/swap_profiler.h<br />
platformsupport/scenes/opengl/texture.cpp<br />
platformsupport/scenes/opengl/texture.h<br />
plugins/platforms/drm/CMakeLists.txt<br />
plugins/platforms/drm/egl_gbm_backend.cpp<br />
plugins/platforms/drm/egl_gbm_backend.h<br />
plugins/platforms/hwcomposer/CMakeLists.txt<br />
plugins/platforms/hwcomposer/egl_hwcomposer_backend.cpp<br />
plugins/platforms/hwcomposer/egl_hwcomposer_backend.h<br />
plugins/platforms/virtual/CMakeLists.txt<br />
plugins/platforms/virtual/egl_gbm_backend.cpp<br />
plugins/platforms/virtual/egl_gbm_backend.h<br />
plugins/platforms/virtual/virtual_backend.cpp<br />
plugins/platforms/wayland/CMakeLists.txt<br />
plugins/platforms/wayland/egl_wayland_backend.cpp<br />
plugins/platforms/wayland/egl_wayland_backend.h<br />
plugins/platforms/x11/common/CMakeLists.txt<br />
plugins/platforms/x11/common/eglonxbackend.cpp<br />
plugins/platforms/x11/common/eglonxbackend.h<br />
plugins/platforms/x11/standalone/CMakeLists.txt<br />
plugins/platforms/x11/standalone/glxbackend.cpp<br />
plugins/platforms/x11/standalone/glxbackend.h<br />
plugins/platforms/x11/windowed/CMakeLists.txt<br />
plugins/platforms/x11/windowed/x11windowed_backend.cpp<br />
plugins/scenes/CMakeLists.txt<br />
plugins/scenes/opengl/CMakeLists.txt<br />
plugins/scenes/opengl/opengl.json<br />
plugins/scenes/opengl/scene_opengl.cpp<br />
plugins/scenes/opengl/scene_opengl.h<br />
scene.h<br />
scene_opengl.cpp<br />
scene_opengl.h</div></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: </strong>plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>