D8493: Make Folder View screen aware

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Oct 26 14:41:23 UTC 2017


broulik added inline comments.

INLINE COMMENTS

> amantia wrote in foldermodel.cpp:1314
> It can be and it is reached. m_screen != -1 means it is a containment, screen == -1 means there is no screen information stored yet. This happens e.g when using the updated code with an existing plasma-*appletsrc file.

Sorry, I misread both as `m_screen`

> amantia wrote in foldermodel.cpp:1659
> This is not a cast between library boundaries, but I don't mind to use qobject_cast either.

It's faster.

> amantia wrote in screenmapper.cpp:51
> I need both the key and the value and AFAIK it is not supported in current Qt version.

Right. Again, misread something :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8493

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid
Cc: broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171026/661d0ff2/attachment.html>


More information about the Plasma-devel mailing list