D8168: kcm_input: Refactor the code and add support for libinput under X11

David Edmundson noreply at phabricator.kde.org
Tue Oct 24 13:10:47 UTC 2017


davidedmundson added inline comments.

INLINE COMMENTS

> FindXorgLibinput.cmake:8
> +#
> +# Copyright (c) 2015 David Edmundson <davidedmundson at kde.org>
> +#

that's not your name...

> CMakeLists.txt:58
>  
> -if (SYNAPTICS_FOUND AND X11_Xinput_FOUND)
> +if (SYNAPTICS_FOUND AND XORGLIBINPUT_FOUND AND X11_Xinput_FOUND)
>      add_subdirectory(touchpad)

do you mean "AND"  especially given this is optional?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8168

To: xuetianweng, davidedmundson, mart
Cc: ngraham, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171024/7e453acf/attachment.html>


More information about the Plasma-devel mailing list