D8421: Port the dict applet to KF5 and QtQuick 2

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:4
> +import org.kde.plasma.components 2.0 as PlasmaComponents
> +import org.kde.plasma.plasmoid 2.0
> +import org.kde.plasma.core 2.0 as PlasmaCore

Unused?

> main.qml:22
> +        implicitWidth: 400
> +        Keys.onReturnPressed: {
> +            if (input.text === "") {

`onAccepted` instead of `Keys.onReturnPressed`

> main.qml:33
> +
> +    WebEngineView {
> +        id: web

Does this need a `Layout.fillWidth: true` and `Layout.fillHeight: true`? The `TextField` probably also needs `Layout.fillWidth`?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D8421

To: dfaure, #plasma
Cc: broulik, davidedmundson, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171023/05e0daf0/attachment-0001.html>