D8421: Port the dict applet to KF5 and QtQuick 2

[David Edmundson]

davidedmundson added a comment.


  Cool, thanks!
  
  > Adding dict applet to desktop, works.
  
  Have you added it to the panel?

INLINE COMMENTS

> main.qml:20
> +        placeholderText: i18n("Enter word to define here")
> +        // If this was widgets, I'd use QFontMetrics...
> +        implicitWidth: 400

then use font metrics...http://doc.qt.io/qt-5/qml-qtquick-fontmetrics.html

or in this Plasmoid case use Units.gridUnit * 40

which is gonna be basically the same.

> main.qml:37
> +        implicitHeight: 400
> +        implicitWidth: 400
> +    }

it's a bit rubbish, but:

zoom: Units.devicePixelRatio

should sort out DPI.
(not tested)

> metadata.desktop:119
>  X-KDE-ServiceTypes=Plasma/Applet
> -X-KDE-Library=plasma_applet_dict
> +# Provides the config dialog
> +#X-KDE-Library=plasma_applet_dict

no it doesn't

> dict_object.h:2
> +/*
> + * Copyright (C) 2017 David Faure <faure at kde.org>
> + *

Plasma core provides a dataengine QML exposer.
https://api.kde.org/frameworks/plasma-framework/html/classPlasma_1_1DataSource.html

Is there a reason we made a specialised QML wrapper? 
(not that I object to this)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D8421

To: dfaure, #plasma
Cc: davidedmundson, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171022/25501ef7/attachment-0001.html>