D8344: Add physicalSize to the Screens API

Bhushan Shah noreply at phabricator.kde.org
Mon Oct 23 04:19:54 UTC 2017


bshah added inline comments.

INLINE COMMENTS

> hwcomposer_backend.cpp:197
>           static const qreal factor = 25.4;
> -         o->setPhysicalSize(QSizeF(qreal(pixel.width() * 1000) / qreal(attr_values[2]) * factor,
> -                                   qreal(pixel.height() * 1000) / qreal(attr_values[3]) * factor).toSize());
> +         m_physicalSize = QSizeF(qreal(pixel.width() * 1000) / qreal(attr_values[2]) * factor,
> +                                 qreal(pixel.height() * 1000) / qreal(attr_values[3]) * factor);

This breaks the build.. will fix it however.

  /workspace/build/plugins/platforms/hwcomposer/hwcomposer_backend.cpp: In function ‘KWayland::Server::OutputInterface* KWin::createOutput(hwc_composer_device_1_t*)’:
  /workspace/build/plugins/platforms/hwcomposer/hwcomposer_backend.cpp:197:10: error: ‘m_physicalSize’ was not declared in this scope
            m_physicalSize = QSizeF(qreal(pixel.width() * 1000) / qreal(attr_values[2]) * factor,

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8344

To: graesslin, #kwin, #plasma, mart
Cc: bshah, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171023/48d70fe8/attachment.html>


More information about the Plasma-devel mailing list