<table><tr><td style="">bshah added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8344" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8344#inline-35970" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">hwcomposer_backend.cpp:197</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">static</span> <span style="color: #aa4000">const</span> <span class="n">qreal</span> <span class="n">factor</span> <span style="color: #aa2211">=</span> <span style="color: #601200">25.4</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">o</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">setP</span>hysicalSize<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">QSizeF</span><span class="p">(</span><span class="n">qreal</span><span class="p">(</span><span class="n">pixel</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1000</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span class="n">qreal</span><span class="p">(</span><span class="n">attr_values</span><span class="p">[</span><span style="color: #601200">2</span><span class="p">])</span> <span style="color: #aa2211">*</span> <span class="n">factor</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"> </span><span class="n">qreal</span><span class="p">(</span><span class="n">pixel</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1000</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span class="n">qreal</span><span class="p">(</span><span class="n">attr_values</span><span class="p">[</span><span style="color: #601200">3</span><span class="p">])</span> <span style="color: #aa2211">*</span> <span class="n">factor<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">toSize</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">m_p</span>hysicalSize<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n">QSizeF</span><span class="p">(</span><span class="n">qreal</span><span class="p">(</span><span class="n">pixel</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1000</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span class="n">qreal</span><span class="p">(</span><span class="n">attr_values</span><span class="p">[</span><span style="color: #601200">2</span><span class="p">])</span> <span style="color: #aa2211">*</span> <span class="n">factor</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qreal</span><span class="p">(</span><span class="n">pixel</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1000</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span class="n">qreal</span><span class="p">(</span><span class="n">attr_values</span><span class="p">[</span><span style="color: #601200">3</span><span class="p">])</span> <span style="color: #aa2211">*</span> <span class="n">factor</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This breaks the build.. will fix it however.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">/workspace/build/plugins/platforms/hwcomposer/hwcomposer_backend.cpp: In function ‘KWayland::Server::OutputInterface* KWin::createOutput(hwc_composer_device_1_t*)’:
/workspace/build/plugins/platforms/hwcomposer/hwcomposer_backend.cpp:197:10: error: ‘m_physicalSize’ was not declared in this scope
m_physicalSize = QSizeF(qreal(pixel.width() * 1000) / qreal(attr_values[2]) * factor,</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8344" rel="noreferrer">https://phabricator.kde.org/D8344</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma, mart<br /><strong>Cc: </strong>bshah, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>