D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

[David Edmundson]

davidedmundson added a comment.


  Your Messages.sh doesn't include qml (copy the code in Marco's mouse diff)
  
  -----
  
  Given you're now familiar with this code, can you look through:
  
  https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=CONFIRMED&bug_status=ASSIGNED&bug_status=REOPENED&component=kcm_launch&list_id=1476716&product=systemsettings&query_format=advanced
  
  (there's only 3)  and see if this fixes them, or mark any as wontfix.

INLINE COMMENTS

> launchfeedback.cpp:169
> +
> +    org::kde::kwin::Effects kwin(QStringLiteral("org.kde.KWin"),
> +        QStringLiteral("/Effects"),

how does plasmashell get notified about new TaskbarButtonSettings?

> main.qml:22
> +import QtQuick.Controls 2.0 as QtControls
> +import QtQuick.Dialogs 1.2 as QtDialogs
> +import org.kde.kirigami 2.3 as Kirigami

not used

> main.qml:87
> +
> +                value: kcm.taskManagerNotificationTimeout
> +                onValueChanged: kcm.taskManagerNotificationTimeout = value

once the user clicks the spinbox this binding will break.

When defaults is clicked, how does this update?

> main.qml:88
> +                value: kcm.taskManagerNotificationTimeout
> +                onValueChanged: kcm.taskManagerNotificationTimeout = value
> +

you might want to see valueModified

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8911

To: hein, #plasma, mart, abetts
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171120/6e1a1fac/attachment.html>