<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8911" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Your Messages.sh doesn't include qml (copy the code in Marco's mouse diff)</p>

<hr class="remarkup-hr" />

<p>Given you're now familiar with this code, can you look through:</p>

<p><a href="https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=CONFIRMED&bug_status=ASSIGNED&bug_status=REOPENED&component=kcm_launch&list_id=1476716&product=systemsettings&query_format=advanced" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=CONFIRMED&bug_status=ASSIGNED&bug_status=REOPENED&component=kcm_launch&list_id=1476716&product=systemsettings&query_format=advanced</a></p>

<p>(there's only 3)  and see if this fixes them, or mark any as wontfix.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8911#inline-39660" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">launchfeedback.cpp:169</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">org</span><span style="color: #aa2211">::</span><span class="n">kde</span><span style="color: #aa2211">::</span><span class="n">kwin</span><span style="color: #aa2211">::</span><span class="n">Effects</span> <span class="n">kwin</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"org.kde.KWin"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"/Effects"</span><span class="p">),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">how does plasmashell get notified about new TaskbarButtonSettings?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8911#inline-39659" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:22</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.</span><span style="color: #004012">Controls</span> <span style="color: #601200">2.0</span> <span style="color: #004012">as</span> <span style="color: #004012">QtControls</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.</span><span style="color: #004012">Dialogs</span> <span style="color: #601200">1.2</span> <span style="color: #004012">as</span> <span style="color: #004012">QtDialogs</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">org</span><span class="p">.</span><span style="color: #004012">kde</span><span class="p">.</span><span style="color: #004012">kirigami</span> <span style="color: #601200">2.3</span> <span style="color: #004012">as</span> <span style="color: #004012">Kirigami</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">not used</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8911#inline-39657" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:87</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">value:</span> <span style="color: #004012">kcm</span><span class="p">.</span><span style="color: #004012">taskManagerNotificationTimeout</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">onValueChanged:</span> <span style="color: #004012">kcm</span><span class="p">.</span><span style="color: #004012">taskManagerNotificationTimeout</span> <span style="color: #aa2211">=</span> <span style="color: #004012">value</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">once the user clicks the spinbox this binding will break.</p>

<p style="padding: 0; margin: 8px;">When defaults is clicked, how does this update?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8911#inline-39655" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:88</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">value:</span> <span style="color: #004012">kcm</span><span class="p">.</span><span style="color: #004012">taskManagerNotificationTimeout</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">onValueChanged:</span> <span style="color: #004012">kcm</span><span class="p">.</span><span style="color: #004012">taskManagerNotificationTimeout</span> <span style="color: #aa2211">=</span> <span style="color: #004012">value</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you might want to see valueModified</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8911" rel="noreferrer">https://phabricator.kde.org/D8911</a></div></div><br /><div><strong>To: </strong>hein, Plasma, mart, abetts<br /><strong>Cc: </strong>davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>