D8793: Fix using avatars from the gallery and from local files

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  No objections. It fixes a bug...
  
  But, if you have the time, I'm sure we could come up wtih something much more elegant with some refactoring.
  
  (like storing the pixmap in infToSave, and then just writing it into .face directly)

INLINE COMMENTS

> accountinfo.cpp:458
>      m_model->setData(m_index, QVariant(cJob->destUrl().path()), AccountModel::Face);
>      m_info->face->setIcon(QIcon(m_model->data(m_index, AccountModel::Face).value<QPixmap>()));
> +    // If there is a leftover temp file, remove it

I know this isn't a line you've changed, and I hate it when reviewers comment about something unrelated, but it's on the screen and annoying me.

model->setData( some qstring)
model->data().value<QPixmap>()

how is that ever going to work?

REPOSITORY
  R128 User Manager

BRANCH
  arcpatch-D8793_2

REVISION DETAIL
  https://phabricator.kde.org/D8793

To: ngraham, apol, #plasma, mlaurent, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171115/23852beb/attachment.html>