<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8793" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>No objections. It fixes a bug...</p>

<p>But, if you have the time, I'm sure we could come up wtih something much more elegant with some refactoring.</p>

<p>(like storing the pixmap in infToSave, and then just writing it into .face directly)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8793#inline-39078" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">accountinfo.cpp:458</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">m_model</span><span style="color: #aa2211">-></span><span class="n">setData</span><span class="p">(</span><span class="n">m_index</span><span class="p">,</span> <span class="n">QVariant</span><span class="p">(</span><span class="n">cJob</span><span style="color: #aa2211">-></span><span class="n">destUrl</span><span class="p">().</span><span class="n">path</span><span class="p">()),</span> <span class="n">AccountModel</span><span style="color: #aa2211">::</span><span class="n">Face</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">m_info</span><span style="color: #aa2211">-></span><span class="n">face</span><span style="color: #aa2211">-></span><span class="n">setIcon</span><span class="p">(</span><span class="n">QIcon</span><span class="p">(</span><span class="n">m_model</span><span style="color: #aa2211">-></span><span class="n">data</span><span class="p">(</span><span class="n">m_index</span><span class="p">,</span> <span class="n">AccountModel</span><span style="color: #aa2211">::</span><span class="n">Face</span><span class="p">).</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">QPixmap</span><span style="color: #aa2211">></span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// If there is a leftover temp file, remove it</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I know this isn't a line you've changed, and I hate it when reviewers comment about something unrelated, but it's on the screen and annoying me.</p>

<p style="padding: 0; margin: 8px;">model->setData( some qstring)<br />
model->data().value<QPixmap>()</p>

<p style="padding: 0; margin: 8px;">how is that ever going to work?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R128 User Manager</div></div></div><br /><div><strong>BRANCH</strong><div><div>arcpatch-D8793_2</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8793" rel="noreferrer">https://phabricator.kde.org/D8793</a></div></div><br /><div><strong>To: </strong>ngraham, apol, Plasma, mlaurent, davidedmundson<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>