D8598: FolderView: position files at drop event target position
Andras Mantia
noreply at phabricator.kde.org
Tue Nov 14 13:34:22 UTC 2017
amantia requested changes to this revision.
amantia added a comment.
This revision now requires changes to proceed.
Unfortunately the current approach fails when the folderview points to desktop:/ . In that case the targetUrl in the copyJobStarted is different ("desktop:/foo") from the url we get from the dirlister model ("file://home/user/Desktop/./foo") and thus it fails to find the saved positions from the hash.
Another note is that in the "map" lambda, there is a need to call
m_screenMapper->addMapping(targetUrl.toString(), m_screen, ScreenMapper::DelayedSignal);
so it goes to the right screen (as soon as https://phabricator.kde.org/D8493 gets in). This one could be done in a followup commit though.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8598
To: mwolff, hein, amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171114/6c17e081/attachment-0001.html>
More information about the Plasma-devel
mailing list