<table><tr><td style="">amantia requested changes to this revision.<br />amantia added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8598" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Unfortunately the current approach fails when the folderview points to desktop:/ . In that case the targetUrl in the copyJobStarted is different ("desktop:/foo") from the url we get from the dirlister model ("file://home/user/Desktop/./foo") and thus it fails to find the saved positions from the hash.<br />
Another note is that in the "map" lambda, there is a need to call</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">m_screenMapper->addMapping(targetUrl.toString(), m_screen, ScreenMapper::DelayedSignal);</pre></div>
<p>so it goes to the right screen (as soon as <a href="https://phabricator.kde.org/D8493" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D8493</a> gets in). This one could be done in a followup commit though.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8598" rel="noreferrer">https://phabricator.kde.org/D8598</a></div></div><br /><div><strong>To: </strong>mwolff, hein, amantia<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>