D8608: Fix crash in KAStatsFavouritesModel

Anthony Fieroni noreply at phabricator.kde.org
Thu Nov 2 04:56:10 UTC 2017


anthonyfieroni added inline comments.

INLINE COMMENTS

> kastatsfavoritesmodel.cpp:506
>  {
>      return d->trigger(row, actionId, argument);
>  }

d && d->trigger ?

> kastatsfavoritesmodel.cpp:622
>  {
>      const auto url = d->normalizedId(id).value();
>  

addFavorite has a check, so here it should.

> kastatsfavoritesmodel.cpp:636
>  {
>      const auto url = d->normalizedId(id).value();
>  

dito

> kastatsfavoritesmodel.cpp:655
>  {
>      d->move(from, to);
>  }

dito

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8608

To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171102/8c0a155d/attachment-0001.html>


More information about the Plasma-devel mailing list